Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(icons): make loading icon clockwise #2797

Merged
merged 2 commits into from
Nov 28, 2024
Merged

fix(icons): make loading icon clockwise #2797

merged 2 commits into from
Nov 28, 2024

Conversation

Akryum
Copy link
Contributor

@Akryum Akryum commented Nov 28, 2024 •
edited
Loading

🔗 Linked issue

❓ Type of change

  • 📖 Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • 👌 Enhancement (improving an existing functionality)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

📚 Description

By default the loading animation on buttons is using animate-spin which rotates it a clockwise way. Currently the default loading icon is counter-clockwise so it looks bad.

📝 Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@benjamincanac benjamincanac changed the title fix: default loading icon should be clockwise fix(icons): make loading icon clockwise Nov 28, 2024
@pkg-pr-new pkg.pr.new
Copy link

pkg-pr-new bot commented Nov 28, 2024 

npm i https://pkg.pr.new/@nuxt/ui@2797

commit: 6866395

@benjamincanac benjamincanac merged commit bc2bcb3 into nuxt:v3 Nov 28, 2024
2 checks passed
@benjamincanac
Copy link
Member

Thanks! Didn't notice that 😅

@Akryum Akryum deleted the patch-2 branch November 29, 2024 08:29
@benjamincanac benjamincanac added the v3 #1289 label Dec 9, 2024 — with Volta.net
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
v3 #1289
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Akryum @benjamincanac